[webkit-changes] [WebKit/WebKit] 62bb3c: [popover] Check for modal flag instead of open att...

Rob Buis noreply at github.com
Mon Jun 5 14:35:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62bb3c714cc988dad1913f7c2b6193182b7f4318
      https://github.com/WebKit/WebKit/commit/62bb3c714cc988dad1913f7c2b6193182b7f4318
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Check for modal flag instead of open attribute
https://bugs.webkit.org/show_bug.cgi?id=257412

Reviewed by Tim Nguyen.

Check for modal flag instead of open attribute in checkPopoverValidity check:
https://github.com/whatwg/html/pull/9344

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html:
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::close):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::checkPopoverValidity):

Canonical link: https://commits.webkit.org/264876@main




More information about the webkit-changes mailing list