[webkit-changes] [WebKit/WebKit] 569bdc: Ensure we don't crash with calc(round())

Chirag Shah noreply at github.com
Mon Jun 5 02:27:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 569bdcf08cfad1bb375fb6a15a4304b3ea3a4166
      https://github.com/WebKit/WebKit/commit/569bdcf08cfad1bb375fb6a15a4304b3ea3a4166
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    M LayoutTests/fast/css/calc-parsing-expected.txt
    M LayoutTests/fast/css/calc-parsing.html
    A LayoutTests/fast/css/calc-with-round-crash-expected.txt
    A LayoutTests/fast/css/calc-with-round-crash.html
    M Source/WebCore/css/calc/CSSCalcValue.cpp

  Log Message:
  -----------
  Ensure we don't crash with calc(round())
https://bugs.webkit.org/show_bug.cgi?id=257157
rdar://109503971

Reviewed by Darin Adler.

This change fixes the crash which happens due to us discarding the
children in case of a round to nearest operation.

* LayoutTests/fast/css/calc-parsing-expected.txt:
* LayoutTests/fast/css/calc-parsing.html:
* LayoutTests/fast/css/calc-with-round-crash-expected.txt: Added.
* LayoutTests/fast/css/calc-with-round-crash.html: Added.
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::createCSS):

Canonical link: https://commits.webkit.org/264863@main




More information about the webkit-changes mailing list