[webkit-changes] [WebKit/WebKit] 4eb676: [WGSL] Use the metal compiler to validate wgslc tests

Tadeu Zagallo noreply at github.com
Mon Jun 5 01:36:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4eb67675fc202cb8b9e5a79869a5c9d3aadca10d
      https://github.com/WebKit/WebKit/commit/4eb67675fc202cb8b9e5a79869a5c9d3aadca10d
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/tests/lit.cfg
    M Source/WebGPU/WGSL/tests/valid/type-promotion.wgsl
    M Source/WebGPU/WGSL/wgslc.cpp

  Log Message:
  -----------
  [WGSL] Use the metal compiler to validate wgslc tests
https://bugs.webkit.org/show_bug.cgi?id=257652
rdar://110174039

Reviewed by Mike Wyrzykowski and Myles C. Maxfield.

Instead of using OutputCheck and regular expressions to match the generated Metal
code, we can invoke the Metal compiler to check the code is valid.

* Source/WebGPU/WGSL/Metal/MetalCodeGenerator.cpp:
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/tests/lit.cfg:
* Source/WebGPU/WGSL/tests/valid/type-promotion.wgsl:
* Source/WebGPU/WGSL/wgslc.cpp:
(runWGSL):

Canonical link: https://commits.webkit.org/264859@main




More information about the webkit-changes mailing list