[webkit-changes] [WebKit/WebKit] d0421a: Remaining page height should never be 0

Ahmad Saleem noreply at github.com
Mon Jun 5 01:06:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0421adf295943e06d4bba1254d6dc86f36d8c9d
      https://github.com/WebKit/WebKit/commit/d0421adf295943e06d4bba1254d6dc86f36d8c9d
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    A LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash-expected.txt
    A LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash.html
    A LayoutTests/fast/multicol/zero-height-inner-multicol-at-boundary-crash-expected.txt
    A LayoutTests/fast/multicol/zero-height-inner-multicol-at-boundary-crash.html
    M Source/WebCore/rendering/RenderFragmentedFlow.cpp

  Log Message:
  -----------
  Remaining page height should never be 0

https://bugs.webkit.org/show_bug.cgi?id=257087
rdar://problem/109929893

Reviewed by Alan Baradlay.

Partial Merge: https://chromium.googlesource.com/chromium/src.git/+/3e04625f97ad0ae12a02e5f4b4d1e40973d01d29 & https://chromium.googlesource.com/chromium/src.git/+/2fa8cb1b82fe741f526a5009f17b03158349e681

This patch covers the case where if 'LayoutUnit' reaches infinity, it just uses 'pageLogicalHeight' as 'remainingHeight'.

* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(RenderFragmentedFlow::pageRemainingLogicalHeightForOffset): Add 'else if' case
* LayoutTests/fast/multicol/zero-height-inner-multicol-at-boundary-crash.html: Add Test Case
* LayoutTests/fast/multicol/zero-height-inner-multicol-at-boundary-crash-expected.txt: Add Test Case Expectation
* LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash.html: Add Test Case
* LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/264857@main




More information about the webkit-changes mailing list