[webkit-changes] [WebKit/WebKit] c28221: AX: Elements with the popovertarget attribute shou...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c28221ccaa7733cf6c4a97ad1afbcdfeeab737ad
      https://github.com/WebKit/WebKit/commit/c28221ccaa7733cf6c4a97ad1afbcdfeeab737ad
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-06-03 (Sat, 03 Jun 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/expanded-notification-expected.txt
    M LayoutTests/accessibility/mac/expanded-notification.html
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/html/HTMLFormControlElement.cpp

  Log Message:
  -----------
  AX: Elements with the popovertarget attribute should expose expanded state to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=257666
rdar://105425310

Reviewed by Chris Fleizach.

Per https://github.com/w3c/html-aam/pull/481, buttons with the
`popovertarget` attribute and valid associated popover should expose
expanded state to assistive technologies.

This commit implements that, and also submits a notification to ATs when
a popover is expanded and collapsed.

* LayoutTests/accessibility/mac/expanded-notification-expected.txt:
* LayoutTests/accessibility/mac/expanded-notification.html:
Popover testcase added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onPopoverTargetToggle):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::popoverTargetElement const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::popoverTargetElement const):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::handlePopoverTargetAction const):

Canonical link: https://commits.webkit.org/264852@main