[webkit-changes] [WebKit/WebKit] fced3c: REGRESSION(257658 at main): Unable to exit fullscreen...
Tim Nguyen
noreply at github.com
Thu Jun 1 16:01:03 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fced3c93326628b5ee97b8aee317e8596c9ec9f8
https://github.com/WebKit/WebKit/commit/fced3c93326628b5ee97b8aee317e8596c9ec9f8
Author: Tim Nguyen <ntim at apple.com>
Date: 2023-06-01 (Thu, 01 Jun 2023)
Changed paths:
A LayoutTests/fullscreen/event-listener-prefixed-unprefixed-document-expected.html
A LayoutTests/fullscreen/event-listener-prefixed-unprefixed-document.html
M Source/WebCore/dom/FullscreenManager.cpp
Log Message:
-----------
REGRESSION(257658 at main): Unable to exit fullscreen from video controls on bleacherreport.com
https://bugs.webkit.org/show_bug.cgi?id=257616
rdar://109373298
Reviewed by Jer Noble.
The website was using an event listener for both prefixed & unprefixed APIs on the document object, causing the
library's event listener to fire twice and wrongly track the fullscreen state.
To fix this, extend the check from 260651 at main to cover document event listners as well.
* LayoutTests/fullscreen/event-listener-prefixed-unprefixed-document-expected.html: Added.
* LayoutTests/fullscreen/event-listener-prefixed-unprefixed-document.html: Added.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::dispatchEventForNode):
Canonical link: https://commits.webkit.org/264814@main
More information about the webkit-changes
mailing list