[webkit-changes] [WebKit/WebKit] d59f20: REGRESSION(264722 at main) ASSERTION FAILED: forward ...

Fujii Hironori noreply at github.com
Thu Jun 1 12:53:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d59f20a7765a4fbbc130df8f339424920b737841
      https://github.com/WebKit/WebKit/commit/d59f20a7765a4fbbc130df8f339424920b737841
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp
    M Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp

  Log Message:
  -----------
  REGRESSION(264722 at main) ASSERTION FAILED: forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength in WTF::textUTF16ContextAwareMoveInPrimaryContext
https://bugs.webkit.org/show_bug.cgi?id=257563

Reviewed by Myles C. Maxfield.

textUTF16ContextAwareMoveInPrimaryContext had an assertion checking
`nativeIndex < nativeLength` if `forward` is true. However, this isn't
true if the current context is NoContext. In such a case,
`nativeIndex` can be equal to `nativeLength`. Fixed assertions.

* Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp:
(WTF::textLatin1ContextAwareMoveInPrimaryContext):
(WTF::textLatin1ContextAwareMoveInPriorContext):
* Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp:
(WTF::textUTF16ContextAwareMoveInPrimaryContext):
(WTF::textUTF16ContextAwareMoveInPriorContext):

Canonical link: https://commits.webkit.org/264804@main




More information about the webkit-changes mailing list