[webkit-changes] [WebKit/WebKit] 36a138: [WGSL] AST::Visitor should visit attribute's children

Tadeu Zagallo noreply at github.com
Thu Jun 1 00:05:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36a138f7b86d3bd10166a50030c3cf006fe62d45
      https://github.com/WebKit/WebKit/commit/36a138f7b86d3bd10166a50030c3cf006fe62d45
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
    M Source/WebGPU/WGSL/tests/valid/constants.wgsl

  Log Message:
  -----------
  [WGSL] AST::Visitor should visit attribute's children
https://bugs.webkit.org/show_bug.cgi?id=257483
rdar://110003839

Reviewed by Dan Glastonbury.

Some of attributes have expression children, which should be visited
by the default implementation in AST::Visitor

* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/ConstantRewriter.cpp:
(WGSL::ConstantRewriter::visit):
* Source/WebGPU/WGSL/tests/valid/constants.wgsl:

Canonical link: https://commits.webkit.org/264781@main




More information about the webkit-changes mailing list