[webkit-changes] [WebKit/WebKit] 7e0479: Use sendWithAsyncReply for NetworkMDNSRegister::Re...

Alex Christensen noreply at github.com
Mon Jul 31 15:56:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e047990d22bf44da14a4fa24c0ea3f146a3145e
      https://github.com/WebKit/WebKit/commit/7e047990d22bf44da14a4fa24c0ea3f146a3145e
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h
    M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
    R Source/WebKit/WebProcess/Network/webrtc/MDNSRegisterIdentifier.h
    M Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp
    M Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h
    R Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in

  Log Message:
  -----------
  Use sendWithAsyncReply for NetworkMDNSRegister::RegisterMDNSName
https://bugs.webkit.org/show_bug.cgi?id=259657
rdar://113156914

Reviewed by Chris Dumez.

This removes an unnecessary message receiver and makes it more clear which code paths need to send a reply.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::PendingRegistrationRequest::PendingRegistrationRequest):
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):
(WebKit::pendingRegistrationRequests): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::registerMDNSName):
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h:
* Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in: Removed.

Canonical link: https://commits.webkit.org/266461@main




More information about the webkit-changes mailing list