[webkit-changes] [WebKit/WebKit] e3ec06: Don't call PAL::getWKDDActionContextClass in macOS...

Alex Christensen noreply at github.com
Mon Jul 31 15:30:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3ec0669b5492d884e183bb20547c133233577be
      https://github.com/WebKit/WebKit/commit/e3ec0669b5492d884e183bb20547c133233577be
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/WebKit/Shared/WebHitTestResultData.h
    M Source/WebKit/Shared/mac/WebHitTestResultPlatformData.serialization.in
    M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  Don't call PAL::getWKDDActionContextClass in macOS base system
https://bugs.webkit.org/show_bug.cgi?id=259660
rdar://113156967

Reviewed by Tim Horton and Chris Dumez.

Before 266374 at main we would only call PAL::getWKDDActionContextClass if detectedDataActionContext was non-null.
Now we always call it when decoding a WebHitTestResultPlatformData, which causes a crash in the base system
where the framework doesn't exist.  Use Markable to stop the crash.

* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/Shared/mac/WebHitTestResultPlatformData.serialization.in:
* Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _animationControllerForDataDetectedText]):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

Canonical link: https://commits.webkit.org/266459@main




More information about the webkit-changes mailing list