[webkit-changes] [WebKit/WebKit] 477657: [visionOS] Media: “…” options menu doesn’t present...

Richard Robinson noreply at github.com
Mon Jul 31 12:14:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4776571d7bd69cdb89bb3315120497f74cc23064
      https://github.com/WebKit/WebKit/commit/4776571d7bd69cdb89bb3315120497f74cc23064
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [visionOS] Media: “…” options menu doesn’t present (when in full screen)
https://bugs.webkit.org/show_bug.cgi?id=259589
rdar://112867127

Reviewed by Tim Horton and Aditya Keerthi.

Instead of preventing any ornament from showing at all when in full screen, only hide/show the
ornaments that are present in the window when entering/exiting full screen.

* Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKMRUIPlatterOrnamentProperties initWithDepthDisplacement:windowAlpha:]):
(-[WKFullScreenParentWindowState initWithWindow:]):
(-[WKFullScreenParentWindowState ornamentProperties]):
(-[WKFullScreenWindowController _setOrnamentsHidden:]):
(-[WKFullScreenWindowController _performSpatialFullScreenTransition:completionHandler:]):
(-[WKFullScreenParentWindowState ornamentDepths]): Deleted.

Canonical link: https://commits.webkit.org/266454@main




More information about the webkit-changes mailing list