[webkit-changes] [WebKit/WebKit] b09ccb: ANGLE mtl_render_utils.h various classes have unin...

Kimmo Kinnunen noreply at github.com
Mon Jul 31 11:47:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b09ccb2a5411e524e25e9f1f6f1e15a0fce44b2c
      https://github.com/WebKit/WebKit/commit/b09ccb2a5411e524e25e9f1f6f1e15a0fce44b2c
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h

  Log Message:
  -----------
  ANGLE mtl_render_utils.h various classes have uninitialised std::array<> members
https://bugs.webkit.org/show_bug.cgi?id=255865
rdar://90537480

Reviewed by Dean Jackson.

Initialize all needed std::array<>s via value initialization.
The default initialization does not initialize the array, leading to
uninitialized reads.

The std::array<>s in RenderUtils are value-initialized in the constructor.

* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h:
(rx::mtl::RenderUtils::angle::EnumSize<PixelType>):

Originally-landed-as: 259548.681 at safari-7615-branch (1e04ec38d7f9). rdar://90537480
Canonical link: https://commits.webkit.org/266451@main




More information about the webkit-changes mailing list