[webkit-changes] [WebKit/WebKit] 2524ce: Crash in GridBaselineAlignment::baselineGroupForChild
Brandon Stewart
noreply at github.com
Mon Jul 31 10:43:43 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2524ce648b831949a2646a984cea076e73a0093b
https://github.com/WebKit/WebKit/commit/2524ce648b831949a2646a984cea076e73a0093b
Author: Brandon Stewart <brandonstewart at apple.com>
Date: 2023-07-31 (Mon, 31 Jul 2023)
Changed paths:
A LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html
A LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html
M Source/WebCore/rendering/RenderGrid.cpp
Log Message:
-----------
Crash in GridBaselineAlignment::baselineGroupForChild
https://bugs.webkit.org/show_bug.cgi?id=257509
rdar://110027455
Reviewed by Alan Baradlay.
Certain baseline properties are not properly handled in CSS Masonry.
We will just disable these calculations for now and then remove this in the future.
* LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html: Added.
* LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html: Added.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::rowAxisBaselineOffsetForChild const):
Originally-landed-as: 259548.835 at safari-7615-branch (b63d45649891). rdar://110027455
Canonical link: https://commits.webkit.org/266429@main
More information about the webkit-changes
mailing list