[webkit-changes] [WebKit/WebKit] e50b54: DNSServiceRef can outlive its socket connection to...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e50b54c0585e5846b51d94711b75515282bc3bd8
      https://github.com/WebKit/WebKit/commit/e50b54c0585e5846b51d94711b75515282bc3bd8
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-07-30 (Sun, 30 Jul 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h

  Log Message:
  -----------
  DNSServiceRef can outlive its socket connection to mDNS, causing blocked threads in Networking
rdar://112721318
https://bugs.webkit.org/show_bug.cgi?id=259636

Reviewed by Youenn Fablet.

Be sure to tear down the DNSServiceRef and remove it from our set when error conditions occur.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::mdnsRegister):

* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::PendingRegistrationRequest::PendingRegistrationRequest):
(WebKit::NetworkMDNSRegister::closeAndForgetService):
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):
* Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h:

Canonical link: https://commits.webkit.org/266420@main