[webkit-changes] [WebKit/WebKit] d94ee9: Safari crashes when showing the downloads menu for...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d94ee98c76194e8e618a849534b8401c984f3c7f
      https://github.com/WebKit/WebKit/commit/d94ee98c76194e8e618a849534b8401c984f3c7f
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-07-29 (Sat, 29 Jul 2023)

  Changed paths:
    M Source/WebCore/loader/mac/LoaderNSURLExtras.mm
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    R Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm
    A Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/URLExtras.mm

  Log Message:
  -----------
  Safari crashes when showing the downloads menu for a download with no MIME type
https://bugs.webkit.org/show_bug.cgi?id=259622
rdar://113058721

Reviewed by Wenson Hsieh.

* Source/WebCore/loader/mac/LoaderNSURLExtras.mm:
Add a null check.

* Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm.
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Rename URLCanonicalization to URLExtras and add a (very simple) positive and
negative test for _webkit_suggestedFilenameWithMIMEType, which was what
was triggering this crash.

Canonical link: https://commits.webkit.org/266414@main