[webkit-changes] [WebKit/WebKit] 92ab43: [WebKit] [iOS] Respect `NSUnderlineStyleAttributeN...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92ab43385d577be31ad30ed584400ed0d7b96940
      https://github.com/WebKit/WebKit/commit/92ab43385d577be31ad30ed584400ed0d7b96940
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm

  Log Message:
  -----------
  [WebKit] [iOS] Respect `NSUnderlineStyleAttributeName` when setting attributed marked text
https://bugs.webkit.org/show_bug.cgi?id=259604
rdar://113036183

Reviewed by Richard Robinson.

After the changes in rdar://108610748, UIKit will use `NSUnderlineStyle` with an attribute value of
`NSUnderlineStyleThick` to indicate "highlighted" segments of marked text when live conversion is
active. Currently, our code only checks against `NSBackgroundColor`, so without the changes in this
patch, it would no longer be possible to know which segment in marked text is the selected segment
when using live conversion.

Fix this by checking for this case, alongside the existing `NSBackgroundColor` check.

Test: KeyboardInputTests.MarkedTextSegmentsWithUnderlines

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(extractUnderlines):
* Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

Canonical link: https://commits.webkit.org/266401@main