[webkit-changes] [WebKit/WebKit] 54238f: Convert `embed hidden` into a proper boolean attri...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54238fd39a0d767f3fc4c69e128b1324d6007197
      https://github.com/WebKit/WebKit/commit/54238fd39a0d767f3fc4c69e128b1324d6007197
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/html/HTMLEmbedElement.cpp

  Log Message:
  -----------
  Convert `embed hidden` into a proper boolean attribute

https://bugs.webkit.org/show_bug.cgi?id=259550

Reviewed by Tim Nguyen.

This patch aligns WebKit with Blink / Chromium.

Inspired by: https://chromium-review.googlesource.com/c/chromium/src/+/3565492

This patch makes the 'hidden' attribute behaves as a normal
boolean attribute - presence of the attribute is interpreted as
a "true" value.

This appears to be per-spec:

- https://html.spec.whatwg.org/#the-embed-element
- https://html.spec.whatwg.org/#the-hidden-attribute
- https://html.spec.whatwg.org/#boolean-attribute

* Source/WebCore/html/HTMLEmbedElement.cpp:
(HTMLEmbedElement::collectPresentationalHintsForAttribute): Remove 'attribute' cases and add assert for 'value'
* LayoutTests/TestExpectations: Remove failing test case

Canonical link: https://commits.webkit.org/266399@main