[webkit-changes] [WebKit/WebKit] fdd0bc: Canvas does not show results of CanvasRenderingCon...

Dean Jackson noreply at github.com
Fri Jul 28 12:54:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fdd0bc163f50cc35458a06481a7cc3df056c16a5
      https://github.com/WebKit/WebKit/commit/fdd0bc163f50cc35458a06481a7cc3df056c16a5
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp

  Log Message:
  -----------
  Canvas does not show results of CanvasRenderingContext2D.putImageData until forced re-render.
https://bugs.webkit.org/show_bug.cgi?id=259584
rdar://112901862

Reviewed by Tim Nguyen.

The commit in 263694 at main caused a regression when calculating the dirty region
of a putImageDataUpdate. It accidentally removed a reference marker on a parameter.

* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::computeImageDataRect): Make sure the destRect parameter is a reference because it is updated.
(WebCore::CanvasRenderingContext2DBase::putImageData): Leave a fixme!

Canonical link: https://commits.webkit.org/266397@main




More information about the webkit-changes mailing list