[webkit-changes] [WebKit/WebKit] 1e1fc4: AX: AXObjectCache platform post notification metho...

AndresGonzalezApple noreply at github.com
Fri Jul 28 08:54:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e1fc4fec3001186950e9e52187399d95bb4cb61
      https://github.com/WebKit/WebKit/commit/1e1fc4fec3001186950e9e52187399d95bb4cb61
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
    M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

  Log Message:
  -----------
  AX: AXObjectCache platform post notification methods should keep alive target objects.
https://bugs.webkit.org/show_bug.cgi?id=259583
<rdar://problem/113007046>

Reviewed by Chris Fleizach.

AXObjectCache platform post notification methods may cause an update of the object cache and the removal of the target object of the notification. This patch ensures that the target object of the notification stays alive for the scope of the notification method.

* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):

* Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):

Canonical link: https://commits.webkit.org/266385@main




More information about the webkit-changes mailing list