[webkit-changes] [WebKit/WebKit] ec1a4f: Implement automatic text track selection for 'meta...
Ahmad Saleem
noreply at github.com
Fri Jul 28 01:45:40 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ec1a4f3966b2baf94e25f281dcc8d31346632658
https://github.com/WebKit/WebKit/commit/ec1a4f3966b2baf94e25f281dcc8d31346632658
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2023-07-28 (Fri, 28 Jul 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata-expected.txt
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
Log Message:
-----------
Implement automatic text track selection for 'metadata' tracks
https://bugs.webkit.org/show_bug.cgi?id=259581
rdar://problem/113004825
Reviewed by Eric Carlson.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=189185
Previously 'metadata' tracks were being configured using the "perform
automatic text track selection" algorithm from the the spec, while it
should only have applied step 4 of the "honor user preferences for
automatic text track selection" algorithm.
* Source/WebCore/html/HTMLMediaElement.cpp:
(HTMLMediaElement::configureMetadataTextTrackGroup): function to handle 'metadata' as per spec
(HTMLMediaElement::configureTextTrackGroup): for 'metadatatracks' use new function
* Source/WebCore/html/HTMLMediaElement.h: Add definition for new function
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata-expected.txt: Rebaselined
Canonical link: https://commits.webkit.org/266380@main
More information about the webkit-changes
mailing list