[webkit-changes] [WebKit/WebKit] 835037: Womo Adventure Map Full Screen View is not loading...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83503754658c7bc33c695547c006364c222dbd45
      https://github.com/WebKit/WebKit/commit/83503754658c7bc33c695547c006364c222dbd45
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    A LayoutTests/fast/dynamic/float-containing-block-becomes-out-of-flow-expected.html
    A LayoutTests/fast/dynamic/float-containing-block-becomes-out-of-flow.html
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  -----------
  Womo Adventure Map Full Screen View is not loading properly
https://bugs.webkit.org/show_bug.cgi?id=259570
<rdar://112733052>

Reviewed by Simon Fraser.

Let's just invalidate the floats as intended (and not floats _and_ out-of-flow positioned boxes).

1. out-of-flow box is incorrectly removed from the descendent map on the containing block (in clearDescendantFloats)
2. mutation on the out-of-flow box marks the containing block dirty with "simplified layout is needed"
3. simplified layout is triggered -> out-of-flow box is missing from the map (simplified layout is not supposed to re-populate this map).
-> out-of-flow box stays dirty

* LayoutTests/fast/dynamic/float-containing-block-becomes-out-of-flow-expected.html: Added.
* LayoutTests/fast/dynamic/float-containing-block-becomes-out-of-flow.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingAndInvalidateForLayout):
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):

Canonical link: https://commits.webkit.org/266366@main