[webkit-changes] [WebKit/WebKit] f89b85: [GLib] WPE API test TestWebsiteData/ephemeral webV...

Amanda Falke noreply at github.com
Thu Jul 27 08:42:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f89b851209e2f24cebb1bc866cae430b48e89520
      https://github.com/WebKit/WebKit/commit/f89b851209e2f24cebb1bc866cae430b48e89520
  Author: Amanda Falke <afalke at igalia.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [GLib] WPE API test TestWebsiteData/ephemeral webView needs HeadlessViewBackend
https://bugs.webkit.org/show_bug.cgi?id=259543

Reviewed by Michael Catanzaro.

Make TestWebsiteData/ephemeral pass in new GLib API for WPE by
conditionally creating WPE headless view backend when creating a new GObject
subtype with `g_object_new`'s variadic property_name args passed into
Test::adoptView() as a webView.

In 259433 at main, we moved network session APIs to a new WebKitNetworkSession
class; we need to ensure that a headless WPE backend is created for
webView in this test, similar to when Test::adoptView was introduced in
190570 at main. (We have previously used these patterns/stanzas for WPE ports
in 195914 at main in `TestAutomationSession.cpp`). TestWebsiteData/ephemeral
now passes in WPE for new GLib API.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataEphemeral):
* Tools/TestWebKitAPI/glib/TestExpectations.json

Canonical link: https://commits.webkit.org/266361@main




More information about the webkit-changes mailing list