[webkit-changes] [WebKit/WebKit] 50d6b4: RealtimeOutgoingVideoSource black frame size compu...

youennf noreply at github.com
Thu Jul 27 07:26:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50d6b4d81168e9a238f3c8b0ba540871ef465a4b
      https://github.com/WebKit/WebKit/commit/50d6b4d81168e9a238f3c8b0ba540871ef465a4b
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    A LayoutTests/webrtc/video-rotation-black-expected.txt
    A LayoutTests/webrtc/video-rotation-black.html
    M Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp

  Log Message:
  -----------
  RealtimeOutgoingVideoSource black frame size computation is wrong in case of rotation
https://bugs.webkit.org/show_bug.cgi?id=259472
rdar://112823005

Reviewed by Eric Carlson.

The black frame size is computed from the source settings, which applies the rotation.
In case we use CVO, we should use the intrinsic size before rotation.
Update RealtimeOutgoingVideoSource::sendBlackFramesIfNeeded accordingly.
This ensures we do not resize on receiver side whenever the sender is sending black frames.

Marking test as slow in iOS as it can take more than 14 seconds sometimes.
Marking test as slow in iOS a
Marking test as slow in iOS a* LayoutTests/platform/glib/TestExpectations:
Marking test as slow in iOS a* LayoutTests/platform/ios/TestExpectations:
Marking test as slow in iOS a* LayoutTests/webrtc/video-rotation-black-expected.txt: Added.
Marking test as slow in iOS a* LayoutTests/webrtc/video-rotation-black.html: Added.
* Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::sendBlackFramesIfNeeded):

Canonical link: https://commits.webkit.org/266358@main




More information about the webkit-changes mailing list