[webkit-changes] [WebKit/WebKit] 74de0d: UpdateScrollInfoAfterLayoutTransaction should belo...

Ryosuke Niwa noreply at github.com
Wed Jul 26 21:55:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74de0d0c4a6bf50151e9d37731d2e8686ae63b2c
      https://github.com/WebKit/WebKit/commit/74de0d0c4a6bf50151e9d37731d2e8686ae63b2c
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.h
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  UpdateScrollInfoAfterLayoutTransaction should belong to LocalFrameViewLayoutContext
https://bugs.webkit.org/show_bug.cgi?id=259387

Reviewed by Alan Baradlay.

This patch makes UpdateScrollInfoAfterLayoutTransaction a member variable of LocalFrameViewLayoutContext
instead of belonging to a Vector<UpdateScrollInfoAfterLayoutTransaction> in a NeverDestroyed unique_ptr
for simplicity & clarify.

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::updateScrollInfoAfterLayoutTransaction):
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
(WebCore::LocalFrameViewLayoutContext::updateScrollInfoAfterLayoutTransactionIfExists):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::UpdateScrollInfoAfterLayoutTransaction::UpdateScrollInfoAfterLayoutTransaction): Deleted.
(WebCore::updateScrollInfoAfterLayoutTransactionStack): Deleted.
(WebCore::currentUpdateScrollInfoAfterLayoutTransaction): Deleted.
(WebCore::RenderBlock::beginUpdateScrollInfoAfterLayoutTransaction):
(WebCore::RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction):
(WebCore::RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction):
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layout):

Canonical link: https://commits.webkit.org/266353@main




More information about the webkit-changes mailing list