[webkit-changes] [WebKit/WebKit] 0ef080: CSS Custom Highlights WPT painting-invalidation 00...
Jessica Cheung
noreply at github.com
Wed Jul 26 18:52:27 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ef0801e78b627d421da475271e6f9385e18af4c
https://github.com/WebKit/WebKit/commit/0ef0801e78b627d421da475271e6f9385e18af4c
Author: Jessica Cheung <jcheung23 at apple.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/dom/Document.cpp
Log Message:
-----------
CSS Custom Highlights WPT painting-invalidation 003 & 006, painting-iframe 006 failing due to not updating positions correctly
https://bugs.webkit.org/show_bug.cgi?id=259521
rdar://112907577
Reviewed by Richard Robinson and Ryosuke Niwa.
Added check for live range in Document::collectRangeDataFromRegister because
we do not want to skip if a live range is already set.
Live ranges are able to change.
Took out null checks in Document::updateHighlightPositions to support that
live ranges can change and there are already existing null checks before setting positions.
Updated TestExpectations due to three passing tests.
* LayoutTests/TestExpectations:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::collectRangeDataFromRegister):
(WebCore::Document::updateHighlightPositions):
* Source/WebCore/dom/Range.h:
* Source/WebCore/dom/StaticRange.h:
Canonical link: https://commits.webkit.org/266349@main
More information about the webkit-changes
mailing list