[webkit-changes] [WebKit/WebKit] 1da03a: Web Inspector: give `WI.Spring` a better name and ...

Wed Jul 26 16:39:40 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1da03ab6270654efd0f5896e7de2e6b194572052
      https://github.com/WebKit/WebKit/commit/1da03ab6270654efd0f5896e7de2e6b194572052
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M LayoutTests/inspector/animation/resources/lifecycle-utilities.js
    M LayoutTests/inspector/unit-tests/geometry-expected.txt
    M LayoutTests/inspector/unit-tests/geometry.html
    A LayoutTests/inspector/unit-tests/spring-timing-function-expected.txt
    A LayoutTests/inspector/unit-tests/spring-timing-function.html
    M Source/WebInspectorUI/.eslintrc
    R Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorSpringEditingController.js
    A Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorSpringTimingFunctionEditingController.js
    M Source/WebInspectorUI/UserInterface/Main.html
    M Source/WebInspectorUI/UserInterface/Models/Animation.js
    M Source/WebInspectorUI/UserInterface/Models/Geometry.js
    A Source/WebInspectorUI/UserInterface/Models/SpringTimingFunction.js
    M Source/WebInspectorUI/UserInterface/Models/TextMarker.js
    M Source/WebInspectorUI/UserInterface/Test.html
    M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
    M Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/CodeMirrorTextMarkers.js
    M Source/WebInspectorUI/UserInterface/Views/InlineSwatch.css
    M Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js
    M Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
    M Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
    R Source/WebInspectorUI/UserInterface/Views/SpringEditor.css
    R Source/WebInspectorUI/UserInterface/Views/SpringEditor.js
    A Source/WebInspectorUI/UserInterface/Views/SpringTimingFunctionEditor.css
    A Source/WebInspectorUI/UserInterface/Views/SpringTimingFunctionEditor.js
    M Source/WebInspectorUI/UserInterface/Views/TextEditor.js

  Log Message:
  -----------
  Web Inspector: give `WI.Spring` a better name and move it to its own file
https://bugs.webkit.org/show_bug.cgi?id=259502

Reviewed by Timothy Hatcher.

`WI.Spring` should really be named `WI.SpringTimingFunction` to convey it's true purpose.

It also shouldn't really be in `Source/WebInspectorUI/UserInterface/Models/Geometry.js` since it has nothing to do with geometry.

* Source/WebInspectorUI/UserInterface/Models/SpringTimingFunction.js: Added.
(WI.SpringTimingFunction):
(WI.SpringTimingFunction.fromValues):
(WI.SpringTimingFunction.fromString):
(WI.SpringTimingFunction.prototype.copy):
(WI.SpringTimingFunction.prototype.toString):
(WI.SpringTimingFunction.prototype.solve):
(WI.SpringTimingFunction.prototype.calculateDuration):
* Source/WebInspectorUI/UserInterface/Models/Geometry.js:
(WI.Spring): Deleted.
(WI.Spring.fromValues): Deleted.
(WI.Spring.fromString): Deleted.
(WI.Spring.prototype.copy): Deleted.
(WI.Spring.prototype.toString): Deleted.
(WI.Spring.prototype.solve): Deleted.
(WI.Spring.prototype.calculateDuration): Deleted.
* Source/WebInspectorUI/UserInterface/Models/Animation.js:
(WI.Animation.prototype._updateEffect):
* Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
(WI.AnimationContentView.prototype._refreshPreview):
* Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:
(WI.AnimationDetailsSidebarPanel.prototype._refreshEffectSection):
* Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):

* Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js:
(WI.InlineSwatch.prototype.switch):
(WI.InlineSwatch.else.prototype.switch):
(WI.InlineSwatch.prototype.didDismissPopover):
(WI.InlineSwatch.prototype._fallbackValue):
(WI.InlineSwatch.prototype._swatchElementClicked):
(WI.InlineSwatch.prototype._valueEditorValueDidChange):
* Source/WebInspectorUI/UserInterface/Views/InlineSwatch.css:
(.inline-swatch:is(.bezier, .spring-timing-function, .variable)): Renamed from `.inline-swatch:is(.bezier, .spring, .variable`.
(.inline-swatch:is(.bezier, .box-shadow, .spring-timing-function, .variable)): Renamed from `.inline-swatch:is(.bezier, .box-shadow, .spring, .variable`.
(.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring-timing-function, .variable, .alignment):hover): Renamed from `.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring, .variable, .alignment):hover`.
(.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring-timing-function, .variable, .alignment):active): Renamed from `.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring, .variable, .alignment):active`.
(.inline-swatch:is(.bezier, .box-shadow, .spring-timing-function, .variable) > span): Renamed from `.inline-swatch:is(.bezier, .box-shadow, .spring, .variable) > span`.
Also rename `WI.InlineSwatch.Type.Spring` to `WI.InlineSwatch.Type.SpringTimingFunction`.

* Source/WebInspectorUI/UserInterface/Views/SpringTimingFunctionEditor.js: Renamed from Source/WebInspectorUI/UserInterface/Views/SpringEditor.js.
(WI.SpringTimingFunctionEditor):
(WI.SpringTimingFunctionEditor.createInputsForParameter):
(WI.SpringTimingFunctionEditor.prototype.get element):
(WI.SpringTimingFunctionEditor.prototype.get springTimingFunction):
(WI.SpringTimingFunctionEditor.prototype.set springTimingFunction):
(WI.SpringTimingFunctionEditor.prototype._handleNumberInputInput):
(WI.SpringTimingFunctionEditor.prototype._handleNumberInputKeydown):
(WI.SpringTimingFunctionEditor.prototype._handleNumberSliderInput):
(WI.SpringTimingFunctionEditor.prototype._handleNumberSliderMousedown):
(WI.SpringTimingFunctionEditor.prototype._handleNumberSliderMouseup):
(WI.SpringTimingFunctionEditor.prototype._changeSpringForInput):
(WI.SpringTimingFunctionEditor.prototype._resetPreviewAnimation):
(WI.SpringTimingFunctionEditor.prototype._updatePreviewAnimation):
* Source/WebInspectorUI/UserInterface/Views/SpringTimingFunctionEditor.css: Renamed from Source/WebInspectorUI/UserInterface/Views/SpringEditor.css.
(.spring-timing-function-editor):
(.spring-timing-function-editor > .preview):
(.spring-timing-function-editor > .preview > div):
(.spring-timing-function-editor > .timing):
(.spring-timing-function-editor > .timing > div):
(.spring-timing-function-editor > .timing::before, .spring-timing-function-editor > .timing::after):
(.spring-timing-function-editor > .timing::before):
(.spring-timing-function-editor > .timing::after):
(.spring-timing-function-editor > :is(.preview, .timing) > div):
(.spring-timing-function-editor > .animate:is(.preview, .timing) > div):
(.spring-timing-function-editor > .number-input-container > .number-input-row):
(.spring-timing-function-editor > .number-input-container > .number-input-row > .number-input-row-title):
(.spring-timing-function-editor > .number-input-container > .number-input-row > input):
(.spring-timing-function-editor > .number-input-container > .number-input-row > input::-webkit-inner-spin-button):
(.spring-timing-function-editor > .number-input-container > .number-input-row > input[type="range"]):
* Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorSpringTimingFunctionEditingController.js: Renamed from Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorSpringEditingController.js.
(WI.CodeMirrorSpringTimingFunctionEditingController.prototype.get initialValue):
(WI.CodeMirrorSpringTimingFunctionEditingController.prototype.get cssClassName):
(WI.CodeMirrorSpringTimingFunctionEditingController.prototype.popoverWillPresent):
(WI.CodeMirrorSpringTimingFunctionEditingController.prototype.popoverDidPresent):
(WI.CodeMirrorSpringTimingFunctionEditingController.prototype._handleSpringTimingFunctionEditorSpringTimingFunctionChanged):
Also rename `WI.SpringEditor` to `WI.SpringTimingFunctionEditor`.

* Source/WebInspectorUI/UserInterface/Models/TextMarker.js:
* Source/WebInspectorUI/UserInterface/Views/CodeMirrorTextMarkers.js:
(createCodeMirrorSpringTimingFunctionTextMarkers): Renamed from `createCodeMirrorSpringTextMarkers`.
* Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._updateEditableMarkers):
* Source/WebInspectorUI/UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.createSpringTimingFunctionMarkers): Renamed from `createSpringMarkers`.
(WI.TextEditor.prototype.editingControllerForMarker):
Also rename `WI.TextMarker.Type.Spring` to `WI.TextMarker.Type.SpringTimingFunction`.

* Source/WebInspectorUI/UserInterface/Main.html:
* Source/WebInspectorUI/UserInterface/Test.html:
* Source/WebInspectorUI/.eslintrc:

* LayoutTests/inspector/animation/resources/lifecycle-utilities.js:
* LayoutTests/inspector/unit-tests/geometry.html:
* LayoutTests/inspector/unit-tests/geometry-expected.txt:
* LayoutTests/inspector/unit-tests/spring-timing-function.html: Added.
* LayoutTests/inspector/unit-tests/spring-timing-function-expected.txt: Added.

Canonical link: https://commits.webkit.org/266338@main