[webkit-changes] [WebKit/WebKit] 96d6de: Remove unnecessary headers including other headers

Alex Christensen noreply at github.com
Wed Jul 26 15:32:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96d6de2528b6ff3f706a6eb9aa41e99023a9b44b
      https://github.com/WebKit/WebKit/commit/96d6de2528b6ff3f706a6eb9aa41e99023a9b44b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M Source/WTF/wtf/Vector.h
    M Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
    M Source/WebKit/Platform/IPC/unix/UnixMessage.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm
    M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
    M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
    M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm

  Log Message:
  -----------
  Remove unnecessary headers including other headers
https://bugs.webkit.org/show_bug.cgi?id=259499
rdar://112862626

Reviewed by Tim Horton.

The WebPageProxy::broadcastFrameRemovalToOtherProcesses message was the only reason ProcessIdentifier.h
was included from the widely-included WebPageProxy.h.  Use the sender's connection instead of the sender's ProcessID.

DecoderOrError and LayerCreationProperties required a few includes just for the implicit constructors and destructors.
Make them explicit instead of including an unnecessary header.

Doing this exposed an unnecessary copy in RemoteLayerTreeContext::buildTransaction.  Add some Vector support
to make it a move instead of a copy.

* Source/WTF/wtf/Vector.h:
(WTF::copyToVector):
(WTF::moveToVectorOf):
(WTF::moveToVector):
* Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp:
* Source/WebKit/Platform/IPC/Connection.cpp:
* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:
* Source/WebKit/Platform/IPC/unix/UnixMessage.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::createMobileGestaltSandboxExtensionIfNeeded const):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
* Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm:
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::broadcastFrameRemovalToOtherProcesses):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):

Canonical link: https://commits.webkit.org/266333@main




More information about the webkit-changes mailing list