[webkit-changes] [WebKit/WebKit] 569bed: Web Inspector: give `WI.CubicBezier` a better name...

Wed Jul 26 14:16:32 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 569bedab4430680f37add358ba9a9fe833eba5db
      https://github.com/WebKit/WebKit/commit/569bedab4430680f37add358ba9a9fe833eba5db
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M LayoutTests/inspector/animation/resources/lifecycle-utilities.js
    A LayoutTests/inspector/unit-tests/cubic-bezier-timing-function-expected.txt
    A LayoutTests/inspector/unit-tests/cubic-bezier-timing-function.html
    M LayoutTests/inspector/unit-tests/geometry-expected.txt
    M LayoutTests/inspector/unit-tests/geometry.html
    M Source/WebInspectorUI/.eslintrc
    R Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorBezierEditingController.js
    A Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCubicBezierTimingFunctionEditingController.js
    M Source/WebInspectorUI/UserInterface/Main.html
    M Source/WebInspectorUI/UserInterface/Models/Animation.js
    A Source/WebInspectorUI/UserInterface/Models/CubicBezierTimingFunction.js
    M Source/WebInspectorUI/UserInterface/Models/Geometry.js
    M Source/WebInspectorUI/UserInterface/Models/TextMarker.js
    M Source/WebInspectorUI/UserInterface/Test.html
    M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
    M Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js
    R Source/WebInspectorUI/UserInterface/Views/BezierEditor.css
    R Source/WebInspectorUI/UserInterface/Views/BezierEditor.js
    M Source/WebInspectorUI/UserInterface/Views/CodeMirrorTextMarkers.js
    A Source/WebInspectorUI/UserInterface/Views/CubicBezierTimingFunctionEditor.css
    A Source/WebInspectorUI/UserInterface/Views/CubicBezierTimingFunctionEditor.js
    M Source/WebInspectorUI/UserInterface/Views/InlineSwatch.css
    M Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js
    M Source/WebInspectorUI/UserInterface/Views/Popover.js
    M Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
    M Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
    M Source/WebInspectorUI/UserInterface/Views/TextEditor.js

  Log Message:
  -----------
  Web Inspector: give `WI.CubicBezier` a better name and move it to its own file
https://bugs.webkit.org/show_bug.cgi?id=259501

Reviewed by Timothy Hatcher.

`WI.CubicBezier` should really be named `WI.CubicBezierTimingFunction` to convey it's true purpose.

It also shouldn't really be in `Source/WebInspectorUI/UserInterface/Models/Geometry.js` since it has nothing to do with geometry.

* Source/WebInspectorUI/UserInterface/Models/CubicBezierTimingFunction.js: Added.
(WI.CubicBezierTimingFunction):
(WI.CubicBezierTimingFunction.fromCoordinates):
(WI.CubicBezierTimingFunction.fromString):
(WI.CubicBezierTimingFunction.prototype.get inPoint):
(WI.CubicBezierTimingFunction.prototype.get outPoint):
(WI.CubicBezierTimingFunction.prototype.copy):
(WI.CubicBezierTimingFunction.prototype.toString):
(WI.CubicBezierTimingFunction.prototype.solve):
(WI.CubicBezierTimingFunction.prototype._sampleCurveX):
(WI.CubicBezierTimingFunction.prototype._sampleCurveY):
(WI.CubicBezierTimingFunction.prototype._sampleCurveDerivativeX):
(WI.CubicBezierTimingFunction.prototype._solveCurveX):
* Source/WebInspectorUI/UserInterface/Models/Geometry.js:
(WI.CubicBezier): Deleted.
(WI.CubicBezier.fromCoordinates): Deleted.
(WI.CubicBezier.fromString): Deleted.
(WI.CubicBezier.prototype.get inPoint): Deleted.
(WI.CubicBezier.prototype.get outPoint): Deleted.
(WI.CubicBezier.prototype.copy): Deleted.
(WI.CubicBezier.prototype.toString): Deleted.
(WI.CubicBezier.prototype.solve): Deleted.
(WI.CubicBezier.prototype._sampleCurveX): Deleted.
(WI.CubicBezier.prototype._sampleCurveY): Deleted.
(WI.CubicBezier.prototype._sampleCurveDerivativeX): Deleted.
(WI.CubicBezier.prototype._solveCurveX): Deleted.
* Source/WebInspectorUI/UserInterface/Models/Animation.js:
(WI.Animation.prototype._updateEffect):
* Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
(WI.AnimationContentView.prototype._refreshPreview):
* Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:
(WI.AnimationDetailsSidebarPanel.prototype._refreshEffectSection):
* Source/WebInspectorUI/UserInterface/Views/Popover.js:
(WI.Popover.prototype._animateFrame):
* Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):

* Source/WebInspectorUI/UserInterface/Views/CubicBezierTimingFunctionEditor.js: Renamed from Source/WebInspectorUI/UserInterface/Views/BezierEditor.js.
(WI.CubicBezierTimingFunctionEditor):
(WI.CubicBezierTimingFunctionEditor.createControl):
(WI.CubicBezierTimingFunctionEditor.createCoordinateInput):
(WI.CubicBezierTimingFunctionEditor.prototype.get element):
(WI.CubicBezierTimingFunctionEditor.prototype.set cubicBezierTimingFunction):
(WI.CubicBezierTimingFunctionEditor.prototype.get cubicBezierTimingFunction):
(WI.CubicBezierTimingFunctionEditor.prototype.removeListeners):
(WI.CubicBezierTimingFunctionEditor.prototype.handleEvent):
(WI.CubicBezierTimingFunctionEditor.prototype.handleKeydownEvent):
(WI.CubicBezierTimingFunctionEditor.prototype._handleMousedown):
(WI.CubicBezierTimingFunctionEditor.prototype._handleMousemove):
(WI.CubicBezierTimingFunctionEditor.prototype._handleMouseup):
(WI.CubicBezierTimingFunctionEditor.prototype._updateControlPointsForMouseEvent):
(WI.CubicBezierTimingFunctionEditor.prototype._updateCubicBezierTimingFunction.round):
(WI.CubicBezierTimingFunctionEditor.prototype._updateCubicBezierTimingFunction):
(WI.CubicBezierTimingFunctionEditor.prototype._updateCoordinateInputs):
(WI.CubicBezierTimingFunctionEditor.prototype._updateControl):
(WI.CubicBezierTimingFunctionEditor.prototype._updatePreview):
(WI.CubicBezierTimingFunctionEditor.prototype._triggerPreviewAnimation):
(WI.CubicBezierTimingFunctionEditor.prototype._resetPreviewAnimation):
(WI.CubicBezierTimingFunctionEditor.prototype._handleNumberInputInput):
(WI.CubicBezierTimingFunctionEditor.prototype._handleNumberInputKeydown):
(WI.CubicBezierTimingFunctionEditor.prototype._changeCoordinateForInput):
* Source/WebInspectorUI/UserInterface/Views/CubicBezierTimingFunctionEditor.css: Renamed from Source/WebInspectorUI/UserInterface/Views/BezierEditor.css.
(.cubic-bezier-timing-function-editor):
(.cubic-bezier-timing-function-editor > .preview):
(.cubic-bezier-timing-function-editor > .preview > div):
(.cubic-bezier-timing-function-editor > .timing):
(.cubic-bezier-timing-function-editor > .preview.animate > div, .cubic-bezier-timing-function-editor > .timing.animate):
(@keyframes CubicBezierTimingFunctionPreview):
(.cubic-bezier-timing-function-editor > .curve):
(.cubic-bezier-timing-function-editor > .curve .linear):
(.cubic-bezier-timing-function-editor > .curve .cubic-bezier):
(.cubic-bezier-timing-function-editor > .curve .control-line):
(.cubic-bezier-timing-function-editor > .curve .control-handle):
(.cubic-bezier-timing-function-editor > .curve .control-handle.selected):
(.cubic-bezier-timing-function-editor > .number-input-container):
(.cubic-bezier-timing-function-editor > .number-input-container > input):
* Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCubicBezierTimingFunctionEditingController.js: Renamed from Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorBezierEditingController.js.
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype.get initialValue):
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype.get cssClassName):
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype.popoverWillPresent):
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype.popoverDidPresent):
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype.popoverDidDismiss):
(WI.CodeMirrorCubicBezierTimingFunctionEditingController.prototype._handleCubicBezierTimingFunctionEditorCubicBezierTimingFunctionChanged):
Also rename `WI.BezierEditor` to `WI.CubicBezierTimingFunctionEditor`.

* Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js:
(WI.InlineSwatch):
(WI.InlineSwatch.prototype.didDismissPopover):
(WI.InlineSwatch.prototype._fallbackValue):
(WI.InlineSwatch.prototype._swatchElementClicked):
(WI.InlineSwatch.prototype._valueEditorValueDidChange):
* Source/WebInspectorUI/UserInterface/Views/InlineSwatch.css:
(.inline-swatch:is(.cubic-bezier-timing-function, .spring, .variable)): Renamed from `.inline-swatch:is(.bezier, .spring, .variable)`.
(.inline-swatch:is(.cubic-bezier-timing-function, .box-shadow, .spring, .variable)): Renamed from `.inline-swatch:is(.bezier, .box-shadow, .spring, .variable)`.
(.inline-swatch:not(.read-only):is(.cubic-bezier-timing-function, .box-shadow, .spring, .variable, .alignment):hover): Renamed from `.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring, .variable, .alignment):hover`.
(.inline-swatch:not(.read-only):is(.cubic-bezier-timing-function, .box-shadow, .spring, .variable, .alignment):active): Renamed from `.inline-swatch:not(.read-only):is(.bezier, .box-shadow, .spring, .variable, .alignment):active`.
(.inline-swatch:is(.cubic-bezier-timing-function, .box-shadow, .spring, .variable) > span): Renamed from `.inline-swatch:is(.bezier, .box-shadow, .spring, .variable) > span`.
Also rename `WI.InlineSwatch.Type.Bezier` to `WI.InlineSwatch.Type.CubicBezierTimingFunction`.

* Source/WebInspectorUI/UserInterface/Models/TextMarker.js:
* Source/WebInspectorUI/UserInterface/Views/CodeMirrorTextMarkers.js:
(createCodeMirrorCubicBezierTimingFunctionTextMarkers): Renamed from `createCodeMirrorBezierTextMarkers`.
* Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._updateEditableMarkers):
* Source/WebInspectorUI/UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.createCubicBezierTimingFunctionMarkers): Renamed from `createCubicBezierMarkers`.
(WI.TextEditor.prototype.editingControllerForMarker):
Also rename `WI.TextMarker.Type.Bezier` to `WI.TextMarker.Type.CubicBezierTimingFunction`.

* Source/WebInspectorUI/UserInterface/Main.html:
* Source/WebInspectorUI/UserInterface/Test.html:
* Source/WebInspectorUI/.eslintrc:

* LayoutTests/inspector/animation/resources/lifecycle-utilities.js:
* LayoutTests/inspector/unit-tests/cubic-bezier-timing-function.html: Added.
* LayoutTests/inspector/unit-tests/cubic-bezier-timing-function-expected.txt: Added.
* LayoutTests/inspector/unit-tests/geometry.html:
* LayoutTests/inspector/unit-tests/geometry-expected.txt:

Canonical link: https://commits.webkit.org/266329@main