[webkit-changes] [WebKit/WebKit] e2372f: WebKit fails to stop discovering text manipulation...

Tue Jul 25 18:49:54 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2372fbf8b4b230ac8c0094c18ca149ac35d9609
      https://github.com/WebKit/WebKit/commit/e2372fbf8b4b230ac8c0094c18ca149ac35d9609
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm

  Log Message:
  -----------
  WebKit fails to stop discovering text manipulation items when subframes are observed
https://bugs.webkit.org/show_bug.cgi?id=259511

Reviewed by Wenson Hsieh.

The bug was caused by didCommitLoad always starting text manipulation even if it was
a navigation for the main frame. Stop observing text for manipulation in this case.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/266308@main