[webkit-changes] [WebKit/WebKit] bb1ced: Use WeakHashMap for m_videoElements in VideoFullsc...

Ryosuke Niwa noreply at github.com
Tue Jul 25 16:07:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb1cedbd987226aa5c5115d690ef5576808fbc0e
      https://github.com/WebKit/WebKit/commit/bb1cedbd987226aa5c5115d690ef5576808fbc0e
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

  Log Message:
  -----------
  Use WeakHashMap for m_videoElements in VideoFullscreenManager
https://bugs.webkit.org/show_bug.cgi?id=259498

Reviewed by Eric Carlson.

Use WeakHasMap instead of HashMap of raw pointers.

* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h:
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::removeContext):
(WebKit::VideoFullscreenManager::setupRemoteLayerHosting):
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenToModeWithoutAnimation):
(WebKit::VideoFullscreenManager::updateTextTrackRepresentationForVideoElement):
(WebKit::VideoFullscreenManager::setTextTrackRepresentationContentScaleForVideoElement):
(WebKit::VideoFullscreenManager::setTextTrackRepresentationIsHiddenForVideoElement):

Canonical link: https://commits.webkit.org/266304@main




More information about the webkit-changes mailing list