[webkit-changes] [WebKit/WebKit] eb3e81: REGRESSION: fast/history/visited-link-caret-color....

Richard Robinson noreply at github.com
Tue Jul 25 10:32:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb3e8157099daef872b6b01d9c35d33d1e99ff49
      https://github.com/WebKit/WebKit/commit/eb3e8157099daef872b6b01d9c35d33d1e99ff49
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M LayoutTests/fast/history/visited-link-caret-color-expected.html
    M LayoutTests/fast/history/visited-link-caret-color.html
    M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  -----------
  REGRESSION: fast/history/visited-link-caret-color.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=259469
rdar://111077813

Reviewed by Megan Gardner and Aditya Keerthi.

When the caret doesn't need to use the system accent color, it should just get the color the normal
way, which already both accounts for the visited-ness and any color filter.

* LayoutTests/fast/history/visited-link-caret-color-expected.html:
* LayoutTests/fast/history/visited-link-caret-color.html:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):

Canonical link: https://commits.webkit.org/266295@main




More information about the webkit-changes mailing list