[webkit-changes] [WebKit/WebKit] cc626f: URL pathname and search setter incorrectly strips ...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc626f31c37433b6ed8bb007f1ad67a6f8697639
      https://github.com/WebKit/WebKit/commit/cc626f31c37433b6ed8bb007f1ad67a6f8697639
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt
    M Source/WTF/wtf/URL.cpp
    M Source/WTF/wtf/URL.h
    M Source/WTF/wtf/URLParser.cpp
    M Source/WTF/wtf/URLParser.h

  Log Message:
  -----------
  URL pathname and search setter incorrectly strips trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=259080
rdar://112433299

Reviewed by Alex Christensen.

Potentially (maybe) trim opaque paths after a query or fragment has
been removed. This ensures that re-parsing roundtrips, even when URL
component setters are used.

Additionally, preserve trailing C0 for the path and query setters using
a new shared function.

* LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt:

This is now synchronized up to the latest commit for the url directory:
01b31f8bbcf570218465a08e8dde4442ae8c3565.

* Source/WTF/wtf/URL.cpp:
(WTF::URL::parseAllowingC0AtEnd):
(WTF::URL::setFragmentIdentifier):
(WTF::URL::potentiallyStripTrailingSpacesFromOpaquePath):
(WTF::URL::removeFragmentIdentifier):
(WTF::URL::removeQueryAndFragmentIdentifier):
(WTF::URL::setQuery):
(WTF::URL::setPath):
* Source/WTF/wtf/URL.h:
* Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::parse):
* Source/WTF/wtf/URLParser.h:

Canonical link: https://commits.webkit.org/266252@main