[webkit-changes] [WebKit/WebKit] f53815: Handle SVGLength resolving in an inactive document...

Ahmad Saleem noreply at github.com
Mon Jul 24 09:30:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f538153c22209151c67f41eba0ab10d7672f2e65
      https://github.com/WebKit/WebKit/commit/f538153c22209151c67f41eba0ab10d7672f2e65
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    A LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt
    A LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html
    M Source/WebCore/svg/SVGLengthContext.cpp

  Log Message:
  -----------
  Handle SVGLength resolving in an inactive document gracefully

https://bugs.webkit.org/show_bug.cgi?id=258226
rdar://problem/112704896

Reviewed by Simon Fraser.

Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=196269

If the element associated with the SVGLength is in an inactive document,
there'll be no layout, so renderStyleForLengthResolving() will be able
to exit the loop without finding a RenderStyle to return.

* Source/WebCore/svg/SVGLengthContext.cpp:
(renderStyleForLengthResolving): Remove 'ASSERT_NOT_REACHED'
* LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html: Add Test Case
* LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/266250@main




More information about the webkit-changes mailing list