[webkit-changes] [WebKit/WebKit] 85e47c: [GLib] In new API, update to base data directories...

Amanda Falke noreply at github.com
Mon Jul 24 08:01:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85e47cd2bdd527cd70684647f9bfd50c32dac7d6
      https://github.com/WebKit/WebKit/commit/85e47cd2bdd527cd70684647f9bfd50c32dac7d6
  Author: Amanda Falke <afalke at igalia.com>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [GLib] In new API, update to base data directories in TestWebsiteData configuration test.
https://bugs.webkit.org/show_bug.cgi?id=259427

Reviewed by Michael Catanzaro.

In 260375 at main, we use UnifiedOriginStorageLevel::Basic in the new
GLib API, which means that WebsiteDataStore::defaultLocalStorageDirectory
and WebsiteDataStore::defaultIndexedDBDatabaseDirectory are no longer
respected. Updating the dirs fixes the tests in the new API for WPE and
GTK; this essentially uses WebsiteDataStore:defaultGeneralStorageDirectory.

Some other helpful commit messages I found along the way were 253824 at main,
259132 at main and 260511 at main; noting those here for historical purposes.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration): Update to base directories per new API.
* Tools/TestWebKitAPI/glib/TestExpectations.json: remove failing WPE
test expectation that was added in a "meta gardening" bug ticket.

Canonical link: https://commits.webkit.org/266245@main




More information about the webkit-changes mailing list