[webkit-changes] [WebKit/WebKit] f504bf: Fix some security tests after 266167 at main

Alex Christensen noreply at github.com
Sat Jul 22 11:50:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f504bf12a3e6c82ff1a90de0e3e8b465e0efb5e2
      https://github.com/WebKit/WebKit/commit/f504bf12a3e6c82ff1a90de0e3e8b465e0efb5e2
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-22 (Sat, 22 Jul 2023)

  Changed paths:
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  Fix some security tests after 266167 at main
https://bugs.webkit.org/show_bug.cgi?id=259417

Unreviewed.

266167 at main changed Cocoa's WebKitTestRunner's preferences management
from copying from the newly allocated WKWebViewConfiguration to copying
from the long-living WKPreferencesRef to the newly allocated WKWebViewConfiguration.
This made it so that state set in previous test runs was being carried forward
to future test runs done with the same WebKitTestRunner instance.
This just reverses the copying back to how it was before 266167 at main.
I verified this fixes the tests Fujii noticed in https://bugs.webkit.org/show_bug.cgi?id=259324

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
(WTR::TestController::platformAdjustContext):

Canonical link: https://commits.webkit.org/266231@main




More information about the webkit-changes mailing list