[webkit-changes] [WebKit/WebKit] c73297: REGRESSION(264990 at main) some occlusion regions are...

Etienne Segonzac noreply at github.com
Sat Jul 22 03:38:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c73297d438825df62ee3d1e97ce88fd6a76b49d9
      https://github.com/WebKit/WebKit/commit/c73297d438825df62ee3d1e97ce88fd6a76b49d9
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-07-22 (Sat, 22 Jul 2023)

  Changed paths:
    M LayoutTests/interaction-region/overlay-expected.txt
    M LayoutTests/interaction-region/overlay.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  REGRESSION(264990 at main) some occlusion regions are incorrect
https://bugs.webkit.org/show_bug.cgi?id=259402
<rdar://112668310>

Reviewed by Tim Horton.

We already only looked at ancestors with the same absolute content box
during the `position: fixed` search. But we also need to make sure we
won't occlude siblings.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::isOverlay):
Update the overlay detection logic.

* LayoutTests/interaction-region/overlay-expected.txt:
* LayoutTests/interaction-region/overlay.html:
Add a test covering the change.

Canonical link: https://commits.webkit.org/266227@main




More information about the webkit-changes mailing list