[webkit-changes] [WebKit/WebKit] 54067b: [JSC] Separate JSString::destroy and JSRopeString:...

Yusuke Suzuki noreply at github.com
Fri Jul 21 10:07:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54067b82699d1e3aecf6914325920a443f7648bd
      https://github.com/WebKit/WebKit/commit/54067b82699d1e3aecf6914325920a443f7648bd
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-07-21 (Fri, 21 Jul 2023)

  Changed paths:
    M Source/JavaScriptCore/heap/Heap.h
    M Source/JavaScriptCore/runtime/JSString.h
    M Source/JavaScriptCore/runtime/JSStringInlines.h

  Log Message:
  -----------
  [JSC] Separate JSString::destroy and JSRopeString::destroy
https://bugs.webkit.org/show_bug.cgi?id=259388
rdar://112648672

Reviewed by Keith Miller.

We would like to separate them so that,

1. We can easily collect each sample from profiler.
2. We do not need to have isRope check for JSString case.

* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/runtime/JSString.h:
(JSC::JSString::destroy): Deleted.
* Source/JavaScriptCore/runtime/JSStringInlines.h:
(JSC::JSString::destroy):
(JSC::JSRopeString::destroy):
(JSC::JSString::~JSString): Deleted.

Canonical link: https://commits.webkit.org/266206@main




More information about the webkit-changes mailing list