[webkit-changes] [WebKit/WebKit] 2511c0: Regression(265678 at main) Unable to send a MessagePo...

Chris Dumez noreply at github.com
Thu Jul 20 21:15:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2511c07012f55458e14773bb204fe4f87f1dc081
      https://github.com/WebKit/WebKit/commit/2511c07012f55458e14773bb204fe4f87f1dc081
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    A LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-message-port.https-expected.txt
    A LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-message-port.https.html
    A LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/message-port-processor.js
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  -----------
  Regression(265678 at main) Unable to send a MessagePort to an AudioWorklet
https://bugs.webkit.org/show_bug.cgi?id=259383
rdar://112624534

Reviewed by Dean Jackson.

In 265678 at main, we started validating types being sent via postMessage() to
AudioWorklets, to make sure that these types are actually supposed to be
exposed to AudioWorklet contexts.

Unfortunately, the allow-list was missing the MessagePort type, which is
supposed to be exposed to AudioWorklets. As a result, we were no longer able
to send MessagePorts to AudioWorklets.

This broke the following experiment:
- https://artsandculture.google.com/experiment/viola-the-bird/nAEJVwNkp-FnrQ

* LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-message-port.https-expected.txt: Added.
* LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-postmessage-message-port.https.html: Added.
* LayoutTests/http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/message-port-processor.js: Added.
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::isTypeExposedToGlobalObject):

Canonical link: https://commits.webkit.org/266197@main




More information about the webkit-changes mailing list