[webkit-changes] [WebKit/WebKit] 71f8a0: [visionOS] Autohide system chrome after entering f...

Aditya Keerthi noreply at github.com
Thu Jul 20 17:04:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71f8a0326d29045ef19df3f362a65e067ad24772
      https://github.com/WebKit/WebKit/commit/71f8a0326d29045ef19df3f362a65e067ad24772
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [visionOS] Autohide system chrome after entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=259363
rdar://110958152

Reviewed by Wenson Hsieh.

Autohide system chrome after entering fullscreen, similar to hiding other
fullscreen controls.

Refactor `WKFullScreenViewController` to use the delegate pattern to call into
`WKFullScreenWindowController`, rather than target-action, as there is an
ever-growing list of "actions".

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController dealloc]):
(-[WKFullScreenViewController delegate]):
(-[WKFullScreenViewController setDelegate:]):
(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController _cancelAction:]):
(-[WKFullScreenViewController _toggleDimmingAction:]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController toggleDimming]):
(-[WKFullScreenWindowController showUI]):
(-[WKFullScreenWindowController hideUI]):
(-[WKFullScreenWindowController _toggleSceneDimming]): Deleted.

Canonical link: https://commits.webkit.org/266191@main




More information about the webkit-changes mailing list