[webkit-changes] [WebKit/WebKit] 99ec08: [WebXR] Unify all paths for requesting required AN...

Dan Glastonbury noreply at github.com
Thu Jul 20 16:16:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99ec0890587733fe26468772955c82e66edcf5ed
      https://github.com/WebKit/WebKit/commit/99ec0890587733fe26468772955c82e66edcf5ed
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/platform/graphics/GraphicsContextGL.h
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp

  Log Message:
  -----------
  [WebXR] Unify all paths for requesting required ANGLE extensions for WebXR
https://bugs.webkit.org/show_bug.cgi?id=259354
rdar://109814502

Reviewed by Dean Jackson.

There are two ways to create a WebXR compatible WebGL context. These paths have
a habit of getting out-of-sync. This patch unifies the two paths in calling
`enableRequiredWebXRExtensions` on the underlying GraphicsContextGL. This
function enables all the extensions required to support any combination of
WebXRLayer attributes, which can be independent of the attributes used to create
the WebGLRenderingContext.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::makeXRCompatible):
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::platformInitialize):
(WebCore::GraphicsContextGLCocoa::enableRequiredWebXRExtensions):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(enableRequiredWebXRExtensions):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::enableRequiredWebXRExtensions):

Canonical link: https://commits.webkit.org/266189@main




More information about the webkit-changes mailing list