[webkit-changes] [WebKit/WebKit] bf94cf: CSS Custom Highlights text decoration does not res...

Jessica Cheung noreply at github.com
Thu Jul 20 13:46:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf94cf5ead9445f859403a3d6035ad493a1f52f4
      https://github.com/WebKit/WebKit/commit/bf94cf5ead9445f859403a3d6035ad493a1f52f4
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001.html
    M Source/WebCore/rendering/StyledMarkedText.cpp

  Log Message:
  -----------
  CSS Custom Highlights text decoration does not respect priority
https://bugs.webkit.org/show_bug.cgi?id=259321
rdar://112494779

Reviewed by Wenson Hsieh.

Before if StyledMarkedText was of higher priority, just overrides textDecorationStyles.
Added a function to compute the textDecorationStyles.
Added WPT ref test for painting unclashing lower priority text decoration
over higher priority highlight without text decorations.

* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001.html: Added.
* Source/WebCore/rendering/StyledMarkedText.cpp:
(WebCore::computeStylesForTextDecorations):
(WebCore::coalesceAdjacentWithSameRanges):

Canonical link: https://commits.webkit.org/266184@main




More information about the webkit-changes mailing list