[webkit-changes] [WebKit/WebKit] 6ddbb2: absoluteRects are computed incorrectly for some co...

Simon Fraser noreply at github.com
Wed Jul 19 15:24:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ddbb226ce39d39523d1807bdc4189448ad0621d
      https://github.com/WebKit/WebKit/commit/6ddbb226ce39d39523d1807bdc4189448ad0621d
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    A LayoutTests/fast/block/continuations-bounding-box-expected.txt
    A LayoutTests/fast/block/continuations-bounding-box.html
    A LayoutTests/platform/ios/fast/block/continuations-bounding-box-expected.txt
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  absoluteRects are computed incorrectly for some continuations
https://bugs.webkit.org/show_bug.cgi?id=259279
rdar://112413956

Reviewed by Alan Baradlay.

A <div> inside a <span> triggers continutations, and if you call RenderInline::absoluteRects() on that span,
the rect for the last continuation is wrong. RenderBlock::absoluteRects() needs to subtract its own
location() and add that of the containing block, just like RenderInline::absoluteRects() does.

* LayoutTests/fast/block/continuations-bounding-box-expected.txt: Added.
* LayoutTests/fast/block/continuations-bounding-box.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteRects const):

Canonical link: https://commits.webkit.org/266169@main




More information about the webkit-changes mailing list