[webkit-changes] [WebKit/WebKit] e126b1: Deprecate and disconnect all of WKPageGroupRef

Alex Christensen noreply at github.com
Wed Jul 19 11:56:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e126b11cd15986d620bb3b69a0c93dd8020a6eeb
      https://github.com/WebKit/WebKit/commit/e126b11cd15986d620bb3b69a0c93dd8020a6eeb
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKPage.h
    M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp
    M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h
    M Source/WebKit/UIProcess/API/C/WKPageGroup.cpp
    M Source/WebKit/UIProcess/API/C/WKPageGroup.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Tools/MiniBrowser/playstation/WebContext.cpp
    M Tools/MiniBrowser/playstation/WebContext.h
    M Tools/MiniBrowser/playstation/WebViewWindow.cpp
    M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
    M Tools/TestWebKitAPI/PlatformWebView.h
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp
    R Tools/TestWebKitAPI/Tests/WebKit/PageGroup.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm
    M Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.mm
    M Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm
    M Tools/TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm
    M Tools/TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
    M Tools/TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm
    M Tools/TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm
    M Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
    M Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm
    M Tools/TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp
    M Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
    M Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
    M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
    M Tools/WebKitTestRunner/mac/TestControllerMac.mm
    M Tools/WebKitTestRunner/playstation/TestControllerPlayStation.cpp
    M Tools/WebKitTestRunner/win/TestControllerWin.cpp
    M Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp

  Log Message:
  -----------
  Deprecate and disconnect all of WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=259324
rdar://112499509

Reviewed by Tim Horton.

It is no longer used anywhere.
Its last use was just an object to get the UserContentController
or preferences object from.

* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageGetPageGroup):
* Source/WebKit/UIProcess/API/C/WKPage.h:
* Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp:
(WKPageConfigurationGetPageGroup):
(WKPageConfigurationSetPageGroup):
* Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h:
* Source/WebKit/UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupGetTypeID):
(WKPageGroupCreateWithIdentifier):
(WKPageGroupSetPreferences):
(WKPageGroupGetPreferences):
(WKPageGroupGetUserContentController):
(WKPageGroupAddUserStyleSheet):
(WKPageGroupRemoveAllUserStyleSheets):
(WKPageGroupAddUserScript):
(WKPageGroupRemoveAllUserScripts):
* Source/WebKit/UIProcess/API/C/WKPageGroup.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _pageGroup]):
(-[WKWebViewConfiguration _setPageGroup:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Tools/TestWebKitAPI/PlatformWebView.h:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/PageGroup.cpp: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::platformAdjustContext):
* Tools/WebKitTestRunner/TestController.h:

Canonical link: https://commits.webkit.org/266167@main




More information about the webkit-changes mailing list