[webkit-changes] [WebKit/WebKit] f7e929: Make SampleBufferDisplayLayer creation callback mo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7e9297462fd46cd6bfcf6e75d278216362efef6
      https://github.com/WebKit/WebKit/commit/f7e9297462fd46cd6bfcf6e75d278216362efef6
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
    M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
    M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h

  Log Message:
  -----------
  Make SampleBufferDisplayLayer creation callback more robust in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=259336
rdar://111524567

Reviewed by Eric Carlson.

MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers initialize callback is now making sure to be a no-op if the initialized sample buffer display layer is no longer the one used by MediaPlayerPrivateMediaStreamAVFObjC.
We also make sure for the initialize callback to return true based on the IPC result directly.
We lazily create the video layer if rootLayer is called, following what MediaPlayerPrivateRemote does.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::initialize):
(WebKit::SampleBufferDisplayLayer::setLogIdentifier):
(WebKit::SampleBufferDisplayLayer::rootLayer):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:

Canonical link: https://commits.webkit.org/266160@main