[webkit-changes] [WebKit/WebKit] a44850: Fix SQLiteDatabase::turnOnIncrementalAutoVacuum()

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4485084ec04ac3b43b1eb7c0ae537b7bcc5401f
      https://github.com/WebKit/WebKit/commit/a4485084ec04ac3b43b1eb7c0ae537b7bcc5401f
  Author: Ben Nham <nham at apple.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/sql/SQLiteDatabase.cpp

  Log Message:
  -----------
  Fix SQLiteDatabase::turnOnIncrementalAutoVacuum()
https://bugs.webkit.org/show_bug.cgi?id=259284
rdar://112475480

Reviewed by Chris Dumez.

PulkoMandy from the Haiku port found that turnOnIncrementalAutoVacuum is broken again on trunk due
to 258673 at main. (It was previously fixed in 241334 at main.)

The issue is that we need to call lastError() immediately after the call to columnInt. What we were
doing was calling it immediatley after the destructor for the PRAGMA auto_vacuum statement. So
instead of checking the return code for the statement running, we were checking the return code for
finalizing the statement.

* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

Canonical link: https://commits.webkit.org/266139@main