[webkit-changes] [WebKit/WebKit] 8c01a9: REGRESSION (Safari 16.x?): MediaRecorder ondataava...
youennf
noreply at github.com
Tue Jul 18 08:53:50 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c01a9fbfd350a4feb8e813006005c0dec98c740
https://github.com/WebKit/WebKit/commit/8c01a9fbfd350a4feb8e813006005c0dec98c740
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-07-18 (Tue, 18 Jul 2023)
Changed paths:
M LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html
M LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt
M LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html
A LayoutTests/http/wpt/mediarecorder/record-96KHz-sources-expected.txt
A LayoutTests/http/wpt/mediarecorder/record-96KHz-sources.html
M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm
M Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
M Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
Log Message:
-----------
REGRESSION (Safari 16.x?): MediaRecorder ondataavailable outputs Blobs with size:0 type:""
https://bugs.webkit.org/show_bug.cgi?id=258567
rdar://111393489
Reviewed by Eric Carlson.
Creating an AAC compressor at 96KHz may not be supported.
In case the AAC compressor creation fails, we fallback to 44100Hz.
Covered by added layout test.
Updated existing tests to cope with new audio device and with max sample rate being increased to 96KHz.
* LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html:
* LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
* LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html:
* LayoutTests/http/wpt/mediarecorder/record-96KHz-sources-expected.txt: Added.
* LayoutTests/http/wpt/mediarecorder/record-96KHz-sources.html: Added.
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedUnit::singleton):
* Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::capabilities):
* Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::defaultDevices):
Canonical link: https://commits.webkit.org/266130@main
More information about the webkit-changes
mailing list