[webkit-changes] [WebKit/WebKit] 3f6cf3: RTCRtpSender maxFramerate encoding parameter has n...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f6cf3be66c5ae9b67dd9335773eda572f17a69c
      https://github.com/WebKit/WebKit/commit/3f6cf3be66c5ae9b67dd9335773eda572f17a69c
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/webrtc/video-maxFramerate-expected.txt
    A LayoutTests/webrtc/video-maxFramerate.html
    M Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.cpp
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.h

  Log Message:
  -----------
  RTCRtpSender maxFramerate encoding parameter has no effect
https://bugs.webkit.org/show_bug.cgi?id=259271
rdar://problem/112397603

Reviewed by Eric Carlson.

React to AddOrUpdateSink max_frame_rate_bps signal to enforce maxFramerate by decimating at the source level.
Update RemoteRealtimeVideoSource::remoteVideoFrameAvailable to compute the observed frame rate so that decimation can happen in WebProcess.
Update RealtimeOutgoingVideoSource to call addVideoFrameObserve with specified frame rate.

* LayoutTests/webrtc/video-maxFramerate-expected.txt: Added.
* LayoutTests/webrtc/video-maxFramerate.html: Added.
* Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::startObservingVideoFrames):
(WebCore::RealtimeOutgoingVideoSource::updateBlackFramesSending):
(WebCore::RealtimeOutgoingVideoSource::AddOrUpdateSink):
* Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h:
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
(WebKit::RemoteRealtimeVideoSource::remoteVideoFrameAvailable):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.h:

Canonical link: https://commits.webkit.org/266128@main