[webkit-changes] [WebKit/WebKit] a5aad7: CrashTracer: com.apple.WebKit.WebContent at CoreGr...

Dean Jackson noreply at github.com
Mon Jul 17 17:28:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5aad74576d8c44d3fff0d5b50bbffc485e6ac62
      https://github.com/WebKit/WebKit/commit/a5aad74576d8c44d3fff0d5b50bbffc485e6ac62
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    R Source/WebKit/Shared/cg/ShareableBitmapCG.cpp
    A Source/WebKit/Shared/cg/ShareableBitmapCG.mm
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  CrashTracer: com.apple.WebKit.WebContent at CoreGraphics: CGDataProviderCopyData
https://bugs.webkit.org/show_bug.cgi?id=259296
rdar://29394886

Reviewed by Simon Fraser.

The change in https://commits.webkit.org/262607@main has caused an
occasional out of memory exception to be thrown in CGDataProviderCopyData.
Catch and ignore this exception, while bailing out of the method.

I've added some logging to give more information if we see it again.

This involved changing a .cpp file to .mm.

* Source/WebKit/Shared/cg/ShareableBitmapCG.mm: Renamed from Source/WebKit/Shared/cg/ShareableBitmapCG.cpp.
(WebKit::ShareableBitmapConfiguration::ShareableBitmapConfiguration):
(WebKit::ShareableBitmapConfiguration::validateColorSpace):
(WebKit::wantsExtendedRange):
(WebKit::ShareableBitmapConfiguration::calculateBytesPerPixel):
(WebKit::ShareableBitmapConfiguration::calculateBytesPerRow):
(WebKit::ShareableBitmapConfiguration::calculateBitmapInfo):
(WebKit::ShareableBitmap::createFromImagePixels):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::paint):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createPlatformImage):
(WebKit::ShareableBitmap::createCGImage const):
(WebKit::ShareableBitmap::releaseBitmapContextData):
(WebKit::ShareableBitmap::createImage):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/266119@main




More information about the webkit-changes mailing list