[webkit-changes] [WebKit/WebKit] 517e21: [Cocoa] Support people deleting their Xcode-wide b...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 517e213dc1297f667aa23205d96dffd7648768e1
      https://github.com/WebKit/WebKit/commit/517e213dc1297f667aa23205d96dffd7648768e1
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  [Cocoa] Support people deleting their Xcode-wide build directories
https://bugs.webkit.org/show_bug.cgi?id=259288
rdar://112423180

Reviewed by Myles C. Maxfield.

If the build directory doesn't exist, webkitdirs.pm will either fail or will use
WebKitBuild instead of just allowing Xcode's build system to create the build
directory like it would normally do.

* Tools/Scripts/webkitdirs.pm:
(determineBaseProductDir):
  - Use the default flags for bsd_glob. In addition to expanding tildes,
    it behaves like a posix shell and will return the pattern string
    when there are no matches.
  - Don't treat IDEApplicationwideBuildSettings as a potential build
    directory. It's a dictionary of variable bindings, and while it may
    *contain* a SYMROOT variable we extract a build directory from, it
    is never a directory itself.
  - Only call realpath if a build directory exists (to support building
    through symlinks). realpath returns undef if the dirname given does
    not exist.

Canonical link: https://commits.webkit.org/266114@main