[webkit-changes] [WebKit/WebKit] 940410: CSS Highlights custom-highlight-painting WPT fail ...
Jessica Cheung
noreply at github.com
Mon Jul 17 12:46:42 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 940410f9ac377e3320d0e20a438394434b1501e1
https://github.com/WebKit/WebKit/commit/940410f9ac377e3320d0e20a438394434b1501e1
Author: Jessica Cheung <jcheung23 at apple.com>
Date: 2023-07-17 (Mon, 17 Jul 2023)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/dom/Document.cpp
Log Message:
-----------
CSS Highlights custom-highlight-painting WPT fail due to Position being null
https://bugs.webkit.org/show_bug.cgi?id=259195
rdar://112208193
Reviewed by Ryosuke Niwa.
Added null check in updateHighlightPositions for position.
In special test cases where there are identical ranges,
positions used to be overridden, first set to a non-null position,
then set again to null, flipping back and forth.
Changed TestExpectations due to more tests passing.
* LayoutTests/TestExpectations:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateHighlightPositions):
Canonical link: https://commits.webkit.org/266106@main
More information about the webkit-changes
mailing list